RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Oct 29 06:32:49 UTC 2020


On Thu, 29 Oct 2020 00:59:56 GMT, Jason Tatton <github.com+70893615+jasontatton-aws at openjdk.org> wrote:

>> Please review the improvements which I have made to the java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any further improvements are required.
>> 
>> Thanks,
>> Jason
>
> Jason Tatton has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusted benchmark to use BlackHole and improved String array syntax as advised

Looks fine to me, thanks.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/918


More information about the core-libs-dev mailing list