RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

Fernando Guallini fernando.guallini at oracle.com
Thu Sep 3 10:40:29 UTC 2020


Hi Sean,
Right, it also applies for these tests, changes:
--- a/test/jdk/java/lang/StringBuffer/HugeCapacity.java
+++ b/test/jdk/java/lang/StringBuffer/HugeCapacity.java
- * @requires os.maxMemory >= 6G
+ * @requires (sun.arch.data.model == "64" & os.maxMemory >= 6G)
--- a/test/jdk/java/lang/StringBuilder/HugeCapacity.java
+++ b/test/jdk/java/lang/StringBuilder/HugeCapacity.java
- * @requires os.maxMemory >= 6G
+ * @requires (sun.arch.data.model == "64" & os.maxMemory >= 6G)

Regards,
Fernando

> On 1 Sep 2020, at 17:25, Seán Coffey <sean.coffey at oracle.com> wrote:
> 
> Wouldn't you require the sun.arch.data.model == "64" jtreg config in these tests also ?
> 
> regards,
> Sean.
> 
> On 28/08/2020 19:13, Fernando Guallini wrote:
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> Hi,
>> 
>> May I please get reviews and a sponsor for this trivial change:
>> 
>> webrev: http://cr.openjdk.java.net/~fguallini/8249694/webrev.00/
>> Testbug: https://bugs.openjdk.java.net/browse/JDK-8249694
>> 
>> Tests do not need to have ‘@ignore' because with @requires os.maxMemory is enough to ensure they will not be executed if memory requirements are not satisfied. They run in Mach5 with no issues.
>> 
>> Thanks
>> 
>> -Fernando



More information about the core-libs-dev mailing list