RFR: 8251397: Add release fence to ClassValueMap constructor

Galder Zamarreño github.com+50187+galderz at openjdk.java.net
Sat Sep 12 12:11:10 UTC 2020


On Wed, 9 Sep 2020 12:50:07 GMT, Galder Zamarreño <github.com+50187+galderz at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/ClassValue.java line 386:
>> 
>>> 384:                 // since stores to the fields of ClassValueMap will not be reordered
>>> 385:                 // to occur after the store to the field type.classValueMap
>>> 386:                 UNSAFE.storeFence();
>> 
>> Wait a second, how's that supposed to work? The `storeFence` should be between the end of `new ClassValueMap()` and the
>> store to `classValueMap`.
>
> Ah yes, my bad ��‍♂️

Updated PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/94


More information about the core-libs-dev mailing list