RFR: 8223187: Investigate setLocale() call in jpackage native launcher

[Naoto Sato]

On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> setlocale() affects several C functions. We do not use most of these functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing it I retested jpackage by changing
> locally on machine and using different language as input parameters for jpackage. No issues found.

Although I am curious why the setlocale() call was introduced in the first place, removing it in order to respect the
platform default locale is generally considered a welcoming change. Approving the change assuming locale related
testing has been done.

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/138