RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming

Vyom Tiwari vyommani at gmail.com
Tue Sep 15 08:54:02 UTC 2020


Hi Christoph,
Changes look ok to me.

On Tue, Sep 15, 2020 at 1:26 PM Christoph Langer <clanger at openjdk.java.net>
wrote:

> There are some little flaws in LdapDNSProvider and auxilliary classes,
> mostly in Javadoc.
>
> In detail:
> src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java:
> Unnecessary import
> src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java:
> typo
> src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java:
> Whitespace
> src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java:
> Spelling of "ldap" -> should be
> capitalized
>
> -------------
>
> Commit messages:
>  - JDK-8253155
>
> Changes: https://git.openjdk.java.net/jdk/pull/168/files
>  Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=168&range=00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8253155
>   Stats: 21 lines in 4 files changed: 3 ins; 7 del; 11 mod
>   Patch: https://git.openjdk.java.net/jdk/pull/168.diff
>   Fetch: git fetch https://git.openjdk.java.net/jdk pull/168/head:pull/168
>
> PR: https://git.openjdk.java.net/jdk/pull/168
>


-- 
Thanks,
Vyom


More information about the core-libs-dev mailing list