RFR: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance) [v2]

Jaikiran Pai jpai at openjdk.java.net
Tue Sep 15 12:26:12 UTC 2020


> Can I please get a review and a sponsor for this patch which fixes the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents `unknown`) as noted in [1]. A new test has been
> included in this commit to verify the change. Furthermore, this doesn't impact the `java.util.zip.GZIPInputStream`
> since it ignores [2] this header value while reading the headers from the stream.  [1]
> https://tools.ietf.org/html/rfc1952#page-7 [2]
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/zip/GZIPInputStream.java#L173

Jaikiran Pai has refreshed the contents of this pull request, and previous commits have been removed. The incremental
views will show differences compared to the previous content of the PR. The pull request contains one new commit since
the last revision:

  8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  Reviewed-By:

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/130/files
  - new: https://git.openjdk.java.net/jdk/pull/130/files/afad1261..159684de

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=130&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=130&range=00-01

  Stats: 5 lines in 2 files changed: 1 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/130.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/130/head:pull/130

PR: https://git.openjdk.java.net/jdk/pull/130


More information about the core-libs-dev mailing list