RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary

[Uwe Schindler]

Hi,

I left some comments on the PR.

The tests with ByteBuffers are not testing the bug correctly.

Uwe

Am September 20, 2020 6:14:59 PM UTC schrieb Lance Andersen <lancea at openjdk.java.net>:
>Hi all,
>
>Please review the fix  for JDK-8252739 which addresses an issue
>introduced by
>https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c
>ignored the offset specified by
>Deflater.setDictionary.
>
>Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly as well as the
>java/util/zip and java/util/jar JCK tests.
>
>-------------
>
>Commit messages:
>- Deflater.setDictionary(byte[], int off, int len) ignores the starting
>offset for the dictionary
>
>Changes: https://git.openjdk.java.net/jdk/pull/269/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=269&range=00
>  Issue: https://bugs.openjdk.java.net/browse/JDK-8252739
>  Stats: 186 lines in 2 files changed: 185 ins; 0 del; 1 mod
>  Patch: https://git.openjdk.java.net/jdk/pull/269.diff
>Fetch: git fetch https://git.openjdk.java.net/jdk
>pull/269/head:pull/269
>
>PR: https://git.openjdk.java.net/jdk/pull/269