RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v2]

Lance Andersen lancea at openjdk.java.net
Sun Sep 20 20:42:34 UTC 2020


> Hi all,
> 
> Please review the fix  for JDK-8252739 which addresses an issue introduced by
> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored the offset specified by
> Deflater.setDictionary.  Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly as well as the java/util/zip and
> java/util/jar JCK tests.

Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:

  Additional updates to DeflaterDictionaryTests.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/269/files
  - new: https://git.openjdk.java.net/jdk/pull/269/files/7f3fd5dc..eaf0be8c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=269&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=269&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/269.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/269/head:pull/269

PR: https://git.openjdk.java.net/jdk/pull/269


More information about the core-libs-dev mailing list