RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v2]

Lance Andersen lancea at openjdk.java.net
Sun Sep 20 20:42:34 UTC 2020


On Sun, 20 Sep 2020 18:29:20 GMT, Uwe Schindler <github.com+1005388+uschindler at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Additional updates to DeflaterDictionaryTests.java
>
> The tests with byte buffers (direct and heap) are not using offsets (arrayOffset=0). The direct buffer test uses just a
> series of 0-bytes, so incorrect offsets won't change result. There should be real data copied into the direct buffer.

Minor updates have been made to the tests

-------------

PR: https://git.openjdk.java.net/jdk/pull/269


More information about the core-libs-dev mailing list