RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos

Alexey Bakhtin abakhtin at openjdk.java.net
Tue Sep 22 15:01:20 UTC 2020


On Tue, 22 Sep 2020 14:41:57 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Hi,
>> 
>> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support for Java GSS/Kerberos.
>> Initial review is available at core-devs: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
>> This version removes "tls-unique" CB type from the list of possible channel binding types. The only supported type is
>> "tls-server-end-point"
>> CSR is also updated : https://bugs.openjdk.java.net/browse/JDK-8247311
>> 
>> Thank you
>> Alexey
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 994:
> 
>> 992:     }
>> 993:
>> 994:     private CompletableFuture<X509Certificate> tlsHandshakeCompleted =
> 
> Should be `final`?

Thank you. Agree. It should be final.

-------------

PR: https://git.openjdk.java.net/jdk/pull/278


More information about the core-libs-dev mailing list