RFR: 8218685: jlink --list-plugins needs to be readable and tidy [v5]
Alan Bateman
alanb at openjdk.java.net
Tue Sep 29 10:01:06 UTC 2020
On Mon, 28 Sep 2020 23:05:37 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Additional usage narrowing
>
> Looks good to me. It may be useful to have a regression test to verify the plugin order of the output if possible.
The new AbstractPlugin and each of the implementations extending it look good. The new usages messages look good too. A
few minor formatting nits in a few places but otherwise I think good to go.
-------------
PR: https://git.openjdk.java.net/jdk/pull/305
More information about the core-libs-dev
mailing list