RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

Valerie Peng valeriep at openjdk.java.net
Tue Sep 29 22:25:24 UTC 2020


On Tue, 29 Sep 2020 09:22:25 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Acked-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
>
>> If this feature is not auto-enabled when the SHA3 hardware feature is there, we will have one failure for the following
>> test: test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java
>> 15 #-----testresult-----
>> 16
>> description=file:/home/yangfei/github/jdk/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java
>> 17 elapsed=31546 0:00:31.546 18 end=Mon Sep 21 10:27:58 CST 2020
>> 19 environment=regtest
>> 20 execStatus=Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Option 'UseSHA3Intrinsics' is
>> expected to have 'true' value Option 'UseSHA3Intrinsics' should be enabled by default
>> Any suggestions for this?
> 
> I don't understand your question. There should be two acceptable results, either "Pass" or "Not supported". What else
> is possible?

I have looked at the java security changes, i.e. src/java.base/share/classes/sun/security/provider/SHA3.java. It looks
fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/207


More information about the core-libs-dev mailing list