RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

[Jim Laskey]

On Thu, 1 Apr 2021 18:19:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> We should never close the jimage since java threads can still be running after a hard exit().
>
> src/java.base/share/native/libjimage/imageFile.cpp line 219:
> 
>> 217: // WARNING: Should never close the jimage file.
>> 218: //          Threads may still be running at shutdown.
>> 219: #if 0
> 
> Are you keeping the code in order to re-visit it again? Just wondering why it's not deleted.

Leaving the code as an example of what is required to close in case the topic gets revisited in the future and I get hit by a bus or dementia.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3304