RFR: 8037397: Lost nested character class after intersection && [v3]

Ian Graves igraves at openjdk.java.net
Fri Apr 2 15:48:56 UTC 2021


On Thu, 1 Apr 2021 00:33:26 GMT, Florent Guillaume <github.com+592810+efge at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding a test.
>
> src/java.base/share/classes/java/util/regex/Pattern.java line 2666:
> 
>> 2664:                             } else { // abc&&def
>> 2665:                                 unread();
>> 2666:                                 if(right == null) {
> 
> Missing space after `if`. There will be a unit test as well?
> 
> (Please tell me if these comments aren't suitable or relevant, as I'm not involved in the project.)

Yep, they are suitable thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3291


More information about the core-libs-dev mailing list