RFR: JDK-8264454 : Jaxp unit test from open jdk needs to be improved

Mahendra Chhipa github.com+34924738+mahendrachhipa at openjdk.java.net
Tue Apr 6 15:51:31 UTC 2021


On Wed, 31 Mar 2021 04:19:46 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> JDK-8264454 : Jaxp unit test from open jdk needs to be improved
>
> test/jaxp/javax/xml/jaxp/unittest/common/Bug6350682.java line 47:
> 
>> 45:     @Test
>> 46:     public void testSAXParserFactory() {
>> 47:         runWithAllPerm(() -> Thread.currentThread().setContextClassLoader(null));
> 
> To address item 4 (the environment is changed), a note, something like "this test runs in othervm" can be added here or to the summary.

Added the comment

> test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java line 204:
> 
>> 202: 
>> 203:                 // does it have the right value?
>> 204:                 if (!expectedLex.equals(duration.toString())) {
> 
> Can be changed to assertEquals

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/3274


More information about the core-libs-dev mailing list