RFR: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement

Aleksey Shipilev shade at openjdk.java.net
Mon Apr 19 12:10:34 UTC 2021


On Mon, 19 Apr 2021 09:42:09 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

> Please review the following patch, which fixes the mentioned test case for memory constrained devices. This can be tested on a linux based development machine, using systemd as follows:
> 
> 
> $ systemd-run --user --scope -p MemoryMax=800M -p MemorySwapMax=0 /usr/bin/make TEST="test/jdk/java/lang/String/StringRepeat.java" run-test
> 
> 
> I split up the test case in a part which only executes the small repeat counts, and in one part which executes the huge repeat count. The second part is guarded by a requirement, so it is only executed if enough memory is available.

test/jdk/java/lang/String/StringRepeat.java line 27:

> 25:  * @test
> 26:  * @summary This exercises String#repeat patterns and limits.
> 27:  * @run main/othervm -Xmx2g StringRepeat

So, does `-Xmx2g` make sense in this configuration now?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3566


More information about the core-libs-dev mailing list