RFR: 8265421: java/lang/String/StringRepeat.java test is missing a memory requirement [v2]

Rahul Yadav ryadav at openjdk.java.net
Mon Apr 19 16:13:53 UTC 2021


On Mon, 19 Apr 2021 12:50:07 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

>> Please review the following patch, which fixes the mentioned test case for memory constrained devices. This can be tested on a linux based development machine, using systemd as follows:
>> 
>> 
>> $ systemd-run --user --scope -p MemoryMax=800M -p MemorySwapMax=0 /usr/bin/make TEST="test/jdk/java/lang/String/StringRepeat.java" run-test
>> 
>> 
>> I split up the test case in a part which only executes the small repeat counts, and in one part which executes the huge repeat count. The second part is guarded by a requirement, so it is only executed if enough memory is available.
>
> Christoph Göttschkes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removes -Xmx2g for the first test case instance, which doesn't require a lot of memory.

Marked as reviewed by ryadav (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3566


More information about the core-libs-dev mailing list