RFR: 8265746: Update java.time to use instanceof pattern variable (part II)
Chris Hegarty
chegar at openjdk.java.net
Fri Apr 23 14:34:25 UTC 2021
On Fri, 23 Apr 2021 10:44:30 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time` package to make use of the `instanceof` pattern variable?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
> Patrick
Marked as reviewed by chegar (Reviewer).
src/java.base/share/classes/java/time/Clock.java line 623:
> 621: return (obj instanceof FixedClock other
> 622: && instant.equals(other.instant)
> 623: && zone.equals(other.zone));
The outer set of braces is redundant.
src/java.base/share/classes/java/time/Clock.java line 673:
> 671: return (obj instanceof OffsetClock other
> 672: && baseClock.equals(other.baseClock)
> 673: && offset.equals(other.offset));
The outer set of braces is redundant.
src/java.base/share/classes/java/time/ZonedDateTime.java line 2191:
> 2189: && dateTime.equals(other.dateTime)
> 2190: && offset.equals(other.offset)
> 2191: && zone.equals(other.zone));
same here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3650
More information about the core-libs-dev
mailing list