RFR: 4926314: Optimize Reader.read(CharBuffer) [v9]

Philippe Marschall github.com+471021+marschall at openjdk.java.net
Sun Apr 25 13:49:48 UTC 2021


On Fri, 16 Apr 2021 17:00:16 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Philippe Marschall has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge master
>>  - Fix bug in CharArrayReader and add unit test
>>  - Clean up unit tests
>>  - Revert off-heap code path
>>  - Replace c-style array declarations
>>  - Share work buffer between #skip and #read
>>  - Update copyright year
>>  - Implement review comment
>>  - Revert StreamDecoder changes
>>  - Implement CharArrayReader#read(CharBuffer)
>>  - ... and 5 more: https://git.openjdk.java.net/jdk/compare/d339320e...c4c859e0
>
> test/jdk/java/io/CharArrayReader/ReadCharBuffer.java line 50:
> 
>> 48:     @DataProvider(name = "buffers")
>> 49:     public Object[][] createBuffers() {
>> 50:         // test both on-heap and off-heap buffers has they may use different code paths
> 
> "as they may"

Done, and the other two as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1915


More information about the core-libs-dev mailing list