RFR: 8265418: Clean-up redundant null-checks of Class.getPackageName()

Alan Bateman alanb at openjdk.java.net
Mon Apr 26 08:48:35 UTC 2021


On Mon, 26 Apr 2021 07:57:21 GMT, Сергей Цыпанов <github.com+10835776+stsypanov at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java line 458:
>> 
>>> 456:         private static boolean isSamePackage(Class<?> class1, Class<?> class2) {
>>> 457:             return class1.getClassLoader() == class2.getClassLoader()
>>> 458:                    && class1.getPackageName().equals(class2.getPackageName());
>> 
>> If the j.u.c.atomic code is changed then it will need to be coordinated with Doug Lea's repo. The rest of the changes are good and thanks for following up from the comments in the other issue.
>
> @AlanBateman if DL is not responding, will it be ok to just revert the changes related to `java.util.concurrent`?

That should be fine, the null check in Objects.equals is benign with these usages.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3571


More information about the core-libs-dev mailing list