RFR: 8263512: [macos_aarch64] issues with calling va_args functions from invoke_native

Nick Gasson ngasson at openjdk.java.net
Tue Apr 27 02:16:37 UTC 2021


On Tue, 27 Apr 2021 02:07:50 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/aapcs/AapcsLinker.java line 50:
>> 
>>> 48:  * the ARM 64-bit Architecture".
>>> 49:  */
>>> 50: public class AapcsLinker implements CLinker {
>> 
>> I see why it's called like that - but this is really either AArch64Linker or Arm64Linker. E.g. the platform standard one.
>
> How about StandardAArch64Linker? Otherwise MacOsAArch64Linker sounds like it should be a specialisation of AArch64Linker.

Or LinuxAArch64Linker if we're going to rename the CABI enum AArch64 -> LinuxAArch64? But this would also be used on other OSs that use the Arm ABI spec as-is (e.g. *BSD).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3617


More information about the core-libs-dev mailing list