RFR: 8266179: [macos] jpackage should specify architecture for produced pkg files

Fri Apr 30 12:51:50 UTC 2021

On Fri, 30 Apr 2021 04:22:37 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> jpackage should specify architecture for produced PKG files via hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable on x64 without specifying hostArchitectures which is not correct and if install on arm Mac it will request Rosetta 2. With proposed fix by setting hostArchitectures="x86_x64" if installer contains x64 binaries, it will be installable on x64 Mac and will require Rosetta 2 on arm Mac. hostArchitectures will be set to arm64 if installer contain aarch64 binaries and will gave error when run on x64 Mac and will be installable on arm Mac without triggering installation of Rosetta 2.

The fix looks good. Would it be feasible to include an automated test for this?

-------------

Marked as reviewed by kcr (Author).

PR: https://git.openjdk.java.net/jdk/pull/3807