RFR: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt() [v4]
Сергей Цыпанов
github.com+10835776+stsypanov at openjdk.java.net
Mon Aug 2 11:34:10 UTC 2021
On Mon, 2 Aug 2021 10:52:26 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into 8270160
>> - Merge branch 'master' into 8270160
>>
>> # Conflicts:
>> # src/java.base/share/classes/java/lang/StringLatin1.java
>> - 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 227:
>
>> 225: private void ensureCapacityInternal(int minimumCapacity) {
>> 226: // overflow-conscious code
>> 227: int oldCapacity = capacity();
>
> This doesn't seem related to the intent of the patch, and might distort startup profiles a bit.
Reverted
> src/java.base/share/classes/java/lang/StringLatin1.java line 47:
>
>> 45: public static char charAt(byte[] value, int index) {
>> 46: checkIndex(index, value.length);
>> 47: return getChar(value, index);
>
> Seems unrelated to the gist of the patch, and again might skew startup profiles.
Reverted
-------------
PR: https://git.openjdk.java.net/jdk/pull/4738
More information about the core-libs-dev
mailing list