RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v6]
Severin Gehwolf
sgehwolf at openjdk.java.net
Mon Aug 2 11:45:32 UTC 2021
On Tue, 27 Jul 2021 10:25:22 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> What do you think about accepting, when setting -1/unlimited, a high limit number like 20.000+ as well (and and a comment that on some setups unlimited means just "high number" but not unlimited?
This seems most reasonable. I'd suggest to accept a limit of `> 20000` or `Unlimited` in the test output. In case of it NOT being `Unlimited` for the `--pids-limit=-1` case, I'd also include the actual output in logs with a message that it got accepted as unlimited.
> Another Idea I had was to start a little test java program that creates e.g. 50.000 (or another high number) of threads. If this fails with "unilimited" pids-limit set, we might have a setup like yours and then skip the test (or accept a high number like I suggested).
This seems overkill and prone to failures, IMHO.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4518
More information about the core-libs-dev
mailing list