RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

[Lin Zang]

On Mon, 26 Jul 2021 20:47:59 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>> 
>>  - change since version to 18
>>  - Merge branch 'master' into gzip-field
>>  - Merge branch 'master' into gzip-field
>>  - Add api in GZIPInputStream to get header data
>>  - Merge remote-tracking branch 'upstream/master' into gzip-field
>>  - remove trailing spaces
>>  - Use record and Builder pattern
>>  - add class GZIPHeaderData, refine testcases
>>  - update copyright
>>  - reuse arguments constructor for non-argument one.
>>  - ... and 3 more: https://git.openjdk.java.net/jdk/compare/e627caec...b1868e8f
>
> src/java.base/share/classes/java/util/zip/GZIPHeaderBuilder.java line 136:
> 
>> 134:         return this;
>> 135:     }
>> 136: 
> 
> Is this really needed as a public method ?

>From the spec RFC-1952(https://www.ietf.org/rfc/rfc1952.txt), the FHCRC is an optional field which user can decide whether to use it or not. So here I make it public. 

May be we can enable it by default? Let's discuss it and make the decision :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3072