RFR: 8271868: Warn user when using mac-sign option with unsigned app-image. [v2]

danielpeintner github.com+11281461+danielpeintner at openjdk.java.net
Thu Aug 5 19:00:34 UTC 2021


On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick <herrick at openjdk.org> wrote:

>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8271868: Warn user when using mac-sign option with unsigned app-image.

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java line 142:

> 140:                     SIGN_BUNDLE.fetchFrom(params)).orElse(Boolean.FALSE)) {
> 141:                 // if signing bundle with app-image, warn user if app-image
> 142:                 // is not allready signed.

nitpicking: typo "allready" -> "already"

-------------

PR: https://git.openjdk.java.net/jdk/pull/5004


More information about the core-libs-dev mailing list