RFR: 8271732: Regression in StringBuilder.charAt bounds checking [v3]

[Claes Redestad]

> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to avoid potentially getting two bounds checks in the UTF-16 case. Problem is this optimization cause a regression since `StringUTF16.charAt(..)` checks `index` against the length of the `value` array and not `count`.
> 
> A correct fix that still maintain the possible performance advantage reported by #4738 is to reinstate the `checkIndex(value, count)` and call `StringUTF16.getChar` instead of `charAt`.

Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:

 - Fix copy-paste error
 - Add UTF-16 tests

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5086/files
  - new: https://git.openjdk.java.net/jdk/pull/5086/files/e29c576a..4ef9ccbc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5086&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5086&range=01-02

  Stats: 23 lines in 1 file changed: 18 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5086.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5086/head:pull/5086

PR: https://git.openjdk.java.net/jdk/pull/5086