RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]
Mikhailo Seledtsov
mseledtsov at openjdk.java.net
Tue Aug 17 23:26:27 UTC 2021
On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
>> Please review this change that updates the buildJdkDockerImage() test library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l support for containers is not tested".
>> The initial intent was to extend the buildJdkDockerImage() API of DockerTestUtils to accept custom Dockerfile content.
>> As I analyzed the usage of buildJdkDockerImage() I realized that:
>> - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest"
>> its use has been obsolete for some time, in favor of Dockerfile generated by DockerTestUtils
>> - 3rd argument "buildDirName" is also always the same: "jdk-docker"
>>
>> Hence I thought it would be a good idea to simplify this API and make it up-to-date.
>>
>> Also, since the method signature is being updated, I thought it would be a good idea to also change the name to use more generic container terminology:
>> buildJdkDockerImage() --> buildJdkContainerImage()
>
> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed a comment
Igor, Harold, thank you for review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5134
More information about the core-libs-dev
mailing list