RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v3]

Mandy Chung mchung at openjdk.java.net
Sun Aug 22 22:02:31 UTC 2021


On Sun, 22 Aug 2021 01:53:40 GMT, liach <github.com+7806504+liach at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove separate accessor for static vs instance method
>>   
>>   There is no effective difference when using MethodHandle::dropArgument for static method.   Removing Static*Accessor and Instance*Accessor simplifies the implementation.
>
> src/java.base/share/classes/jdk/internal/reflect/DirectConstructorAccessorImpl.java line 46:
> 
>> 44:             // fast invoker
>> 45:             var mhInvoker = newMethodHandleInvoker(ctor, target);
>> 46:             return new DirectConstructorAccessorImpl(ctor, target);
> 
> The created fast invoker should be passed to the ctor than discarded.

Good catch.  Will fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5027


More information about the core-libs-dev mailing list