RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform [v2]

Naoto Sato naoto at openjdk.java.net
Mon Aug 23 00:24:29 UTC 2021


On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Hi all,
>> 
>> Could you please review the 8269373 bug fixes?
>> 
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg command option. To run non-localized tests, -Duser.language=en and -Duser.country=US options should be added in ProcessBuilder.
>
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8269373: use test opts for process arguments

IMHO, this kind of test that sets the locale forcefully sometimes gives us false positives. I'd rather eliminate that possibility than run tests in different locales

-------------

PR: https://git.openjdk.java.net/jdk/pull/4594


More information about the core-libs-dev mailing list