RFR: 8272347: ObjectMethods::bootstrap should specify NPE if any argument except lookup is null [v2]

Vicente Romero vromero at openjdk.java.net
Wed Aug 25 16:08:25 UTC 2021


On Wed, 25 Aug 2021 02:17:12 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Hi Mandy, I have changed the implementation of the method to explicitly require all arguments but lookup to be non-null as suggested by Brian. I have also covered, I think, all the missing test cases in test `ObjectMethodsTest`, thanks for your comments.
>
> I think you meant requiring `names` to be non-null but `lookup` may still be null.  It's okay to change the spec to require `names` to be non-null.  
> 
> Probably better to mention in `@param names` that `names` is ignored when the `methodName` is `equals` or `hashCode`.

no I think I prefer to force names to be non-null all the time, that way we offer a more consistent interface to users. They don't have to remember what case was for which names can be null.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5226


More information about the core-libs-dev mailing list