RFR: JDK-8276837: [macos]: Error when signing the additional launcher
Alexey Semenyuk
asemenyuk at openjdk.java.net
Wed Dec 1 20:03:22 UTC 2021
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick <herrick at openjdk.org> wrote:
> Before signing, unsign all executables and libraries (not just those in runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has additional launcher works, and results in validly signed launcher and additional launcher (original reported problem).
Changes requested by asemenyuk (Reviewer).
test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 95:
> 93: SigningBase.verifyCodesign(launcherPath, true);
> 94: SigningBase.verifyCodesign(testALPath, true);
> 95: }
Would it make sense to extend the existing test with additional launcher checks instead of creating another one? Packaging of a full JDK with signing probably takes a while
-------------
PR: https://git.openjdk.java.net/jdk/pull/6636
More information about the core-libs-dev
mailing list