RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

Mikhailo Seledtsov mseledtsov at openjdk.java.net
Thu Dec 2 02:03:27 UTC 2021


On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all tests not defined in the lower tiers. `hotspot:tier4` has lots of them, mostly long-running vmTestbase tests, which take many hours even on a very parallel machines.
>> 
>> This, unfortunately, has a chilling effect on `jdk:tier4`, which is seldom run by contributors, because `hotspot:tier4` is in the way. But, there are plenty of fast and stable tests in `jdk:tier4` that can be run in `jdk:tier3`. `jdk_svc` is the example of such tests: management features (including but not limited to JFR) are important to keep from regressions, and significant subset of them runs pretty fast.
>> 
>> So, it makes sense to move some `jdk_svc` tests to `jdk:tier3` to expose it to more contributors. I think the only group we don't want to run is `svc_tools`, which includes lots of non-parallel tests that are rather slow.
>> 
>> Sample run before:
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk:tier3                                174   174     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> 
>> real	2m38.242s
>> user	80m7.216s
>> sys	2m13.846s
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>>> jtreg:test/jdk:tier4                               2904  2901     3     0 <<
>> ==============================
>> TEST FAILURE
>> 
>> real	18m13.933s
>> user	546m50.556s
>> sys	25m7.086s
>> 
>> 
>> Sample run after:
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk:tier3                               1296  1296     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> 
>> real	7m49.017s
>> user	287m30.943s
>> sys	13m20.060s
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>>> jtreg:test/jdk:tier4                               1783  1780     3     0 <<
>> ==============================
>> TEST FAILURE
>> 
>> 
>> real	12m19.973s
>> user	351m48.561s
>> sys	14m51.566s
>
> Hi @shipilev ,
> We need to have someone look at the impact of this on our CI. I don't think we run the tier4 group as defined in our tier 4 so we may not see those execution time savings that offset the extra cost to tier3.

Thanks @dholmes-ora for making sure to examine the impact on the CI. I took a look, and this change should not have considerable adverse impact on Oracle CI. 

Aleksey, the change looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6619


More information about the core-libs-dev mailing list