RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation [v2]

[Magnus Ihse Bursie]

On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> Addition of a configure option --with-cacerts-src='user cacerts folder' to allow developers to specify their own cacerts PEM folder for generation of the cacerts store using the deterministic openjdk GenerateCacerts tool.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - Merge branch 'master' of https://github.com/openjdk/jdk into cacertssrc
>  - 8278080: Add --with-cacerts-src='user cacerts folder' to enable determinsitic cacerts generation
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - 8278080: Add --with-cacerts-src='user cacerts folder' to enable determinsitic cacerts generation
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>

make/modules/java.base/Gendata.gmk line 76:

> 74: ifneq ($(CACERTS_SRC), )
> 75:   GENDATA_CACERTS_SRC := $(CACERTS_SRC)
> 76: endif

Does this even work?! You are reassigning the variable after it has been used. The := assignment means that it not a macro.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6647