Integrated: JDK-8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Joe Darcy darcy at openjdk.java.net
Thu Dec 2 18:21:20 UTC 2021


On Thu, 2 Dec 2021 02:23:59 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Change the test in question to generate its data programmatically to avoid updates with each JDK release. (Assuming this gets pushed before the start of JDK 19, I'll revert the customary changes to the test in set of start-of-19 updates.)
> 
> Running the test, it does probe the same set of values:
> 
> STDOUT:
> test ClassFileVersionsTest.testSupported(53, 0, []): success
> test ClassFileVersionsTest.testSupported(53, 0, [STATIC]): success
> test ClassFileVersionsTest.testSupported(53, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testSupported(53, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testSupported(54, 0, []): success
> test ClassFileVersionsTest.testSupported(55, 0, []): success
> test ClassFileVersionsTest.testSupported(56, 0, []): success
> test ClassFileVersionsTest.testSupported(57, 0, []): success
> test ClassFileVersionsTest.testSupported(58, 0, []): success
> test ClassFileVersionsTest.testSupported(59, 0, []): success
> test ClassFileVersionsTest.testSupported(60, 0, []): success
> test ClassFileVersionsTest.testSupported(61, 0, []): success
> test ClassFileVersionsTest.testSupported(62, 0, []): success
> 
> test ClassFileVersionsTest.testUnsupported(50, 0, []): success
> test ClassFileVersionsTest.testUnsupported(51, 0, []): success
> test ClassFileVersionsTest.testUnsupported(52, 0, []): success
> test ClassFileVersionsTest.testUnsupported(54, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(54, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(54, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(55, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(55, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(55, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(56, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(56, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(56, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(57, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(57, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(57, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(58, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(58, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(58, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(59, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(59, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(59, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(60, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(60, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(60, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(61, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(61, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(61, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(62, 0, [STATIC]): success
> test ClassFileVersionsTest.testUnsupported(62, 0, [TRANSITIVE]): success
> test ClassFileVersionsTest.testUnsupported(62, 0, [TRANSITIVE, STATIC]): success
> test ClassFileVersionsTest.testUnsupported(63, 0, []): success

This pull request has now been integrated.

Changeset: 8b042d14
Author:    Joe Darcy <darcy at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8b042d14b78c66b50495d0d8b559ca3f6744d806
Stats:     69 lines in 1 file changed: 10 ins; 19 del; 40 mod

8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewed-by: alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/6657


More information about the core-libs-dev mailing list