RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v16]

[John Neffenger]

On Thu, 2 Dec 2021 15:35:40 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> Add a new --source-date <TIMESTAMP> (epoch seconds) option to jar and jmod to allow specification of time to use for created/updated jar/jmod entries. This then allows the ability to make the content deterministic.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into jarjmodtimestamps
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - Merge branch 'jarjmodtimestamps' of github.com:andrew-m-leonard/jdk into jarjmodtimestamps
>  - Update src/jdk.jlink/share/classes/jdk/tools/jmod/JmodOutputStream.java
>    
>    Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>  - Merge branch 'master' of https://github.com/openjdk/jdk into jarjmodtimestamps
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>    
>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>  - ... and 14 more: https://git.openjdk.java.net/jdk/compare/8d9cb2ef...290a4903

I can't think of any more ways to break this. I tested pairs of JavaFX builds again on all six Linux architectures, from 32-bit ARM to IBM mainframe. I tested some of my own Java and JavaFX projects. All builds created identical artifacts: JAR files (classes, sources, and Javadoc), JMOD archives, and even all the files under the `jlink` output directory.

The `jpackage` tool fails to create reproducible Debian packages, but that seems to be nothing more than some inconsistent symbolic links under `lib/runtime/legal`.

Good job, Andrew!

-------------

Marked as reviewed by jgneff (no project role).

PR: https://git.openjdk.java.net/jdk/pull/6481