RFR: 8278185: Custom JRE cannot find non-ASCII named module inside
Naoto Sato
naoto at openjdk.java.net
Mon Dec 6 17:05:14 UTC 2021
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura <tnakamura at openjdk.org> wrote:
> Could you review this fix?
>
> Problem:
> Custom JRE generated by jlink cannot find non-ASCII named modules included inside the JRE.
>
> Cause and fix:
> If module or package name was composed by ASCII then non-ASCII characters,
> ImageStringsReader:stringFromByteBufferMatches() miscalculated the length of matched string. The first part of ASCII characters was missing. This patch corrected the value.
>
> Testing:
> tier1 and tier2 on Linux have no regression.
> I wasn't able to create an automate test for this issue. I appreciate any advice.
Regression tests for `ResourceBundle` class have tests that dynamically generate modules. Although I have not used non-ASCII module names, tests under `test/jdk/java/util/ResourceBundle/modules` may shed some light on the subject.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6693
More information about the core-libs-dev
mailing list