RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v23]

Andrew Leonard aleonard at openjdk.java.net
Fri Dec 10 14:09:06 UTC 2021


On Fri, 10 Dec 2021 11:51:53 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8276766: Enable jar and jmod to produce deterministic timestamped content
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> test/jdk/tools/jar/SourceDateDataProvider.java line 54:
> 
>> 52:                                };
>> 53: 
>> 54:     @DataProvider(name = "SourceDateData.valid")
> 
> This class file is really not needed as you can just add the DataProvider to ReproducableJar example:
> 
>  ```
>   @DataProvider
>     private Object[][] invalidSourceDates() {
>         return new Object[][] {
>                                  {"1976-06-24T01:02:03+00:00"},
>                                   {"1980-01-01T00:00:01+00:00"},
>                                   {"2100-01-01T00:00:00+00:00"},
>                                   {"2138-02-18T00:00:00-11:00"},
>                                   {"2006-04-06T12:38:00"},
>                                   {"2012-08-24T16"}
>         };
>     }
> 
> 
> And the Test will just use
> 
> `@Test(dataProvider= "invalidStourceDates")`

Thanks Lance, that is simpler, i've changed it

-------------

PR: https://git.openjdk.java.net/jdk/pull/6481


More information about the core-libs-dev mailing list