RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v24]

[Lance Andersen]

On Fri, 10 Dec 2021 14:09:00 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> Add a new --source-date <TIMESTAMP> (epoch seconds) option to jar and jmod to allow specification of time to use for created/updated jar/jmod entries. This then allows the ability to make the content deterministic.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8276766: Enable jar and jmod to produce deterministic timestamped content
>   
>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>

Hi Andrew,

The latest Mach5 runs remain clean and the updates look good so you are good to integrate when you are ready!

test/jdk/tools/jar/ReproducibleJar.java line 43:

> 41: import java.nio.file.Files;
> 42: import java.nio.file.attribute.FileTime;
> 43: import java.util.Arrays;

This can be removed I believe

test/jdk/tools/jar/ReproducibleJar.java line 113:

> 111: 
> 112:     @AfterMethod
> 113:     public void runAfter() throws Throwable {

throws clause is not needed

test/jdk/tools/jar/ReproducibleJar.java line 160:

> 158:       */
> 159:     @Test(dataProvider = "invalidSourceDates")
> 160:     public void testInvalidSourceDate(String sourceDate) throws Throwable {

throws clause is not needed

test/jdk/tools/jar/ReproducibleJar.java line 281:

> 279:       * Remove the directory and its contents
> 280:       */
> 281:     static boolean cleanup(File dir) throws Throwable {

The return type is not used and the throws clause can be removed

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6481