Integrated: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base"

Johannes Kuhn github.com+652983+dasbrain at openjdk.java.net
Mon Feb 1 08:12:52 UTC 2021


On Fri, 8 Jan 2021 09:38:40 GMT, Johannes Kuhn <github.com+652983+DasBrain at openjdk.org> wrote:

> Simple fix - one line change: https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0.
> 
> Most of the changes come from an additional test that fails without this fix:
> 
>      Error: Unable to load main class somelib.test.TestMain in module somelib
>     	java.lang.IllegalAccessError: superclass access check failed: class somelib.test.TestMain (in module somelib) cannot access class java.lang.Object (in module java.base) because module java.base does not export java.lang to module somelib
> 
> As described in JDK-8259395.
> You can view the output of the test without patch here: https://github.com/DasBrain/jdk/runs/1668078245
> 
> Thanks to @AlanBateman for pointing out the right fix.

This pull request has now been integrated.

Changeset: cf942081
Author:    Johannes Kuhn <info at j-kuhn.de>
Committer: Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cf942081
Stats:     454 lines in 11 files changed: 453 ins; 0 del; 1 mod

8259395: Patching automatic module with additional packages re-creates module without "requires java.base"

Reviewed-by: attila, alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/2000


More information about the core-libs-dev mailing list