RFR: 8259074: regex benchmarks and tests

Claes Redestad redestad at openjdk.java.net
Mon Feb 1 10:24:41 UTC 2021


On Sat, 30 Jan 2021 21:32:27 GMT, Martin Buchholz <martin at openjdk.org> wrote:

>> 8259074: regex benchmarks and tests
>
> @amalloy - you are invited to comment on regex content
> @cl4es @shipilev - you are invited to point out my jmh bad practices

The assertion discussion aside, the micros look fine to me. 

With an eye towards reducing total run time I'd ask you to consider if all parameter combinations are useful or if we can get the same value after some pruning.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1940


More information about the core-libs-dev mailing list