RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v10]

Brent Christian bchristi at openjdk.java.net
Mon Feb 1 23:49:45 UTC 2021


On Mon, 1 Feb 2021 22:23:02 GMT, Mahendra Chhipa <github.com+34924738+mahendrachhipa at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   throwing the specific exceptions.

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 159:

> 157:     private void match(String actual, String expected) {
> 158:         System.out.println("actual:" + actual + "expected:" + expected);
> 159:         assert((actual == null && expected == null) || actual.equals(expected.trim()));

I don't think this check is done, because assertions aren't enabled.  This should be changed to explicitly throw an exception.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2170


More information about the core-libs-dev mailing list