RFR: JDK-8260335: [macos] Running app using relative path causes problems [v2]

[Andy Herrick]

On Tue, 2 Feb 2021 17:10:15 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 86 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8260335
>>  - JDK-8260335: [macos] Running app using relative path causes problems
>>  - 8260522: Clean up warnings in hotspot JTReg runtime tests
>>    
>>    Reviewed-by: lfoltan, coleenp
>>  - 8259398: Super word not applied to a loop with byteArrayViewVarHandle
>>    
>>    Reviewed-by: vlivanov, thartmann, chagedorn
>>  - 8260669: Missing quotes in fixpath.sh
>>    
>>    Reviewed-by: tbell, iris, mikael, ihse
>>  - 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
>>    
>>    Reviewed-by: alanb
>>  - 8257498: Remove useless skeleton predicates
>>    
>>    Reviewed-by: roland, thartmann
>>  - 8260591: Shenandoah: improve parallelism for concurrent thread root scans
>>    
>>    Reviewed-by: zgu, rkennke
>>  - 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
>>    
>>    Reviewed-by: attila, alanb
>>  - 8260577: Unused code in AbstractCompiler after Shark compiler removal
>>    
>>    Reviewed-by: shade, chagedorn, kvn
>>  - ... and 76 more: https://git.openjdk.java.net/jdk/compare/caf2c20d...af31a50b
>
> src/jdk.jpackage/share/native/common/FileUtils.cpp line 57:
> 
>> 55: tstring dirname(const tstring &path) {
>> 56:     tstring::size_type pos;
>> 57:     if (tstrings::endsWith(path, _T("/."))) {
> 
> I'd add `|| tstrings::endsWith(path, _T("\."))` to cover similar case for Windows paths

yes - dirname not currently used this way on windows (passed a directory) but should make it work consistently)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2260