RFR: 8261036: Reduce classes loaded by CleanerFactory initialization [v3]

Roger Riggs rriggs at openjdk.java.net
Wed Feb 3 18:00:44 UTC 2021


On Wed, 3 Feb 2021 16:11:08 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> This patch refactors CleanerFactory and InnocuousThread so that we need to load fewer PrivilegedActions. This slightly reduce the number of classes we always load on bootstrap, slightly reducing static and dynamic footprint (default CDS archive -4Kb).
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only set priority if requested

Marked as reviewed by rriggs (Reviewer).

src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 64:

> 62:      * Returns a new InnocuousThread with its context class loader
> 63:      * set to the system class loader, inheriting the current thread priority
> 64:      */

Needs a period at the end of the sentence.  Which is getting too long for the method summary.
(Even though javadoc is not usually generated for this implementation class).
Split the qualification about thread priority into a separate sentence.

src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 88:

> 86:     /**
> 87:      * Returns a new InnocuousThread with an auto-generated thread name,
> 88:      * inheriting the current thread priority.

ditto; separate sentence.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2380


More information about the core-libs-dev mailing list