RFR: JDK-8261237: isClassPathAttributePresent use try with resources with JarFile

Matthias Baesken mbaesken at openjdk.java.net
Fri Feb 5 15:28:46 UTC 2021


Hello,
Currently in jdk/internal/vm/VMSupport.java , we create a JarFile without a related finally clause or try with resources. That should better be changed.
See also the Sonar check result :

https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&open=AXcqM8zf8sPJZZzON5qG&resolved=false&severities=BLOCKER&types=BUG

    public static boolean isClassPathAttributePresent(String path) {
        try {
            Manifest man = (new JarFile(path)).getManifest();
Use try-with-resources or close this "JarFile" in a "finally" clause.

-------------

Commit messages:
 - JDK-8261237

Changes: https://git.openjdk.java.net/jdk/pull/2429/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2429&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261237
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2429.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2429/head:pull/2429

PR: https://git.openjdk.java.net/jdk/pull/2429


More information about the core-libs-dev mailing list