RFR: JDK-8261237: isClassPathAttributePresent use try with resources with JarFile

[Alan Bateman]

On Fri, 5 Feb 2021 15:23:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hello,
> Currently in jdk/internal/vm/VMSupport.java , we create a JarFile without a related finally clause or try with resources. That should better be changed.
> See also the Sonar check result :
> 
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&open=AXcqM8zf8sPJZZzON5qG&resolved=false&severities=BLOCKER&types=BUG
> 
>     public static boolean isClassPathAttributePresent(String path) {
>         try {
>             Manifest man = (new JarFile(path)).getManifest();
> Use try-with-resources or close this "JarFile" in a "finally" clause.

src/java.base/share/classes/jdk/internal/vm/VMSupport.java line 87:

> 85:      * path is not a JAR file or some other error occurs.
> 86:      */
> 87:     public static boolean isClassPathAttributePresent(String path) {

Is isClassPathAttributePresent used anywhere? I remember we added VMSupport for use by JVMTI and the attach mechanism but I don't see any usages of this method now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2429