RFR: 8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo
Alexey Semenyuk
asemenyuk at openjdk.java.net
Mon Feb 8 16:22:41 UTC 2021
On Mon, 8 Feb 2021 08:49:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> SonarCloud instance reports as new warning after JDK-8254702:
>
> This branch can not be reached because the condition duplicates a previous condition in the same sequence of "if/else if" statements.
>
> char* getJvmLauncherLibPath(void) {
> ...
> if (PACKAGE_TYPE_RPM == pkg->type) {
> pkgQueryCmd = "rpm -ql '%s' 2>/dev/null";
> } else if (PACKAGE_TYPE_RPM == pkg->type) { <--- here
> pkgQueryCmd = "dpkg -L '%s' 2>/dev/null";
>
> Seems like an obvious typo.
>
> Additional tests:
> - [x] Linux x86_64 (Ubuntu) `tools/jpackage`
Marked as reviewed by asemenyuk (Committer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/2452
More information about the core-libs-dev
mailing list