RFR: 8259074: regex benchmarks and tests [v5]

Martin Buchholz martin at openjdk.java.net
Mon Feb 8 18:12:43 UTC 2021


On Tue, 2 Feb 2021 13:10:29 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix imports
>
> Marked as reviewed by redestad (Reviewer).

@cl4es Your comment sent me back to jmh re-education camp.  I never looked at warmup iterations numbers before, but I now see they can be very useful for eyeballing how long warmup takes.  Very JVM-dependent of course.  In practice I will stick with my rule of thumb that 10 seconds of warmup is good enough for any simple program, and that happens to be the JMH warmup time default.  OTOH I think more than one warmup iteration is overkill for most benchmarks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1940


More information about the core-libs-dev mailing list