RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v4]
Michael McMahon
michaelm at openjdk.java.net
Mon Feb 8 22:06:26 UTC 2021
On Mon, 8 Feb 2021 16:50:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>>
>> - Merge branch 'master' into 8252971-socket-attributes
>> - add specific check for unix domain socket
>> - Merge branch 'master' into 8252971-socket-attributes
>> - update
>> - update
>> - update
>> - update
>> - update after Alan's first review
>> - Merge branch 'master' into 8252971-socket-attributes
>> - test update
>> - ... and 1 more: https://git.openjdk.java.net/jdk/compare/4e1be4ef...746b4762
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 862:
>
>> 860: * and a handle to the socket file if it is.
>> 861: */
>> 862: private long openSocketForReadAttributeAccess() {
>
> The methods here throw WindowsException when they fail and might be better to keep it consistent and throw WindowsException rather than returning INVALID_HANDLE_VALUE.
Okay
-------------
PR: https://git.openjdk.java.net/jdk/pull/2424
More information about the core-libs-dev
mailing list