RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v5]
Michael McMahon
michaelm at openjdk.java.net
Mon Feb 8 22:06:20 UTC 2021
> Could I get the following change reviewed please? It fixes a problem (in JEP380) on Windows where some file operations on Unix domain sockets were not working and led to the feature being disabled on Windows 2019 Server in JDK 16. So, the fix re-enables the feature on all versions of Windows that support it.
>
> The test checks all the file APIs that were affected by the problem. The change touches the code that handles symbolic links in Windows (since they are implemented as NTFS reparse points, like Unix sockets), but I didn't add any specific testing in this area, as I assume the existing unit tests for NIO symbolic links should cover that. If I should add more tests here, then I can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
update
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2424/files
- new: https://git.openjdk.java.net/jdk/pull/2424/files/746b4762..f644e939
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2424&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2424&range=03-04
Stats: 29 lines in 2 files changed: 2 ins; 16 del; 11 mod
Patch: https://git.openjdk.java.net/jdk/pull/2424.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2424/head:pull/2424
PR: https://git.openjdk.java.net/jdk/pull/2424
More information about the core-libs-dev
mailing list